Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mediaFileServices): dont perform check on original file #817

Merged
merged 1 commit into from
Jun 28, 2023
Merged

fix(mediaFileServices): dont perform check on original file #817

merged 1 commit into from
Jun 28, 2023

Conversation

kishore03109
Copy link
Contributor

@kishore03109 kishore03109 commented Jun 28, 2023 •
edited
Loading

Problem

There exists older repos in which we are unable to rename the files in prod because constrains were placed on the previous file change

Solution

disregard checks for the old file name

Tests

I have replicated the files that the agency had trouble renaming and placed it in my repo.
I was now able to rename the files properly via cms

Manual test

  • go to any test repo
  • change a file name to 2012.09.19.BT_blah.pdf
  • Login and rename the file name directly via the cms

@kishore03109 kishore03109 marked this pull request as ready for review June 28, 2023 03:33
@kishore03109 kishore03109 requested a review from a team June 28, 2023 03:33
@kishore03109 kishore03109 merged commit 23a2899 into develop Jun 28, 2023
@mergify mergify bot deleted the fix/renameFilesThatHaveDisallowedCharacters branch June 28, 2023 04:53
@seaerchin seaerchin mentioned this pull request Jul 6, 2023
Merged
@kishore03109 kishore03109 mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaerchin seaerchin seaerchin approved these changes

@alexanderleegs alexanderleegs alexanderleegs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kishore03109 @alexanderleegs @seaerchin